Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PICARD-2876: Update the Options > Advanced > Maintenance page #2434

Merged
merged 1 commit into from
Apr 25, 2024

Conversation

rdswift
Copy link
Collaborator

@rdswift rdswift commented Apr 25, 2024

Summary

  • This is a…
    • Bug fix
    • Feature addition
    • Refactoring
    • Minor / simple change (like a typo)
    • Other
  • Describe this change in 1-2 sentences: Update the Options > Advanced > Maintenance page

Problem

In the Options > Advanced > Maintenance page, you can only scroll the list of unused option settings if you first enable the "Remove selected options" checkbox. That should not be required to see all of the unused settings.

Solution

Update the Options > Advanced > Maintenance page:

  • update the enabling logic for the unused setting item selections and "Remove selected options" checkbox to allow scrolling the unused settings list without having to enable the "Remove selected options" checkbox
  • relocate the "Remove selected options" checkbox to save space
  • update the wording of the instructions to clarify and save space
  • update the tab order

The updated page looks like:

image

Action

Additional actions required:

- update the enabling logic for the unused setting item selections and
"Remove selected options" checkbox to allow scrolling the unused
settings list without having to enable the "Remove selected options"
checkbox
- relocate the "Remove selected options" checkbox to save space
- update the wording of the instructions to clarify and save space
- update the tab order
@rdswift rdswift requested review from phw and zas April 25, 2024 15:56
Copy link
Member

@phw phw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@zas zas merged commit 055547b into metabrainz:master Apr 25, 2024
41 checks passed
@rdswift rdswift deleted the options_maint_page_update branch April 25, 2024 17:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants